Repository navigation
Fix division panics from oversized trial quotients - #47
Closed
ryanduguid wants to merge 1 commit into
Closed
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #46: valid divisions, including
3.4028236692093846347 / 1.8446744073709551616, panic inbits.Div64. Count equal normalised high words as four-word dividends and route oversized first or later trial quotients through the existing fallback.Evidence
make fuzz-all 20; division and the shared helper each pass a further 60-second run.Risk
An oversized estimate can now use the allocating fallback even when the final quotient fits in u128. Public APIs, truncation, signs and input immutability are preserved.
Unverified
Other operating systems and architectures. Upstream Test and Fuzz workflows report
action_requiredwith no jobs yet. Timing equivalence is unproven on this shared machine. Linux 386 passes the new regressions and all fuzz seeds; its full suite retains the same fiveTestAppendBinaryfailure names as master.